Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace isAnonymous property with externalUserId #1

Closed
wants to merge 1 commit into from

Conversation

denis-rossati
Copy link
Member

Summary

This PR will remove the isAnonymous property and introduce the externalUserId property to follow the Session changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@denis-rossati denis-rossati added the bc-break This change is not backward-compatible label Nov 19, 2024
@denis-rossati denis-rossati self-assigned this Nov 19, 2024
@Fryuni
Copy link
Member

Fryuni commented Nov 21, 2024

This repo is generated automatically. We shouldn't have direct PRs to it.

@Fryuni Fryuni closed this Nov 21, 2024
@Fryuni Fryuni deleted the update-is-anonymous branch November 21, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bc-break This change is not backward-compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants