Fix HTTP1.1 pipeline teardown #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The teardown can be triggered by a connection close of the remote side.
This sends a `LAST` at the bottom of the supply pipeline. That last needs
to bubble up the supply chain and arrive in Cro::HTTP::Client (possibly
also applies to the server) for it to tear down its pipeline. Otherwise the
supply chain will for the most part be torn down and further emits of
requests will sit forever in the topmost Supply::Preserving which then has
no taps.
The symptom without this fix is that a pipeline that the remote end closed
(i.e. hasn't been used for 60 seconds or so) will cause all subsequent uses
of that pipeline to error out with
Exceeded timeout for headers when attempting to access http://foop
jnthn
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The teardown can be triggered by a connection close of the remote side. This sends a
LASTat the bottom of the supply pipeline. That last needs to bubble up the supply chain and arrive in Cro::HTTP::Client (possibly also applies to the server) for it to tear down its pipeline. Otherwise the supply chain will for the most part be torn down and further emits of requests will sit forever in the topmost Supply::Preserving which then has no taps.The symptom without this fix is that a pipeline that the remote end closed (i.e. hasn't been used for 60 seconds or so) will cause all subsequent uses of that pipeline to error out with