Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect ignore_errors when extracting error messages from event data #329

Conversation

d-honeybadger
Copy link
Collaborator

Description of your changes

Fixes #328

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Create an ansiblerun with a task that is known to fail but set ignore_errors to true, i.e.

     tasks:
        - ignore_errors: true
          file:
            path: /nonexistent
            state: file

And have that run fail for some other reason (i.e. another task that fails and does not have ignore_errors set).
The failed ansiblerun should have a message about the faile task without ignore_errors, but should not have any messages about the one with ignore_errors

Signed-off-by: Dasha Komsa <komsa.darya@gmail.com>
@morningspace
Copy link
Collaborator

LGTM

@morningspace morningspace merged commit 8373f6e into crossplane-contrib:main May 5, 2024
7 checks passed
@fahedouch fahedouch added this to the v0.6.1 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When extracting failure messages "ignore_errors" isn't respected
3 participants