Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crossplane runtime latest #63

Merged

Conversation

nalbury
Copy link
Contributor

@nalbury nalbury commented Nov 17, 2023

Description of your changes

Went to import the APIs here as a pkg in another internal controller we've been developing and I ran into some compatibility issues with crossplane-runtime in other provider APIs (e.g. upbound AWS). This PR:

  • Updates the crossplane-tools and crossplane-runtime to current latest versions
    • also updates controller-runtime and other crossplane-runtime dependencies to latest
  • Regenerates API methods (gets rid of methods which expect a deprecated/removed field) by running make generate
  • Patches a handful of other changes required due to the crossplane-runtime and controller-runtime updates

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

I've tested this locally by:

  • creating a local k8s cluster
  • installing the bitnami kafka chart (helm args/flags taken from .github/workflows/ci.yml running make test
  • configuring port forwarding for the headless kafka svc
  • running make test

@nalbury nalbury force-pushed the update-crossplane-runtime-latest branch from 372691c to 4a1e31b Compare November 17, 2023 14:16
…ne-tools

Signed-off-by: Nick Albury <nalbury@handy.com>
Signed-off-by: nalbury <nickalbury@gmail.com>
Signed-off-by: Nick Albury <nalbury@handy.com>
Signed-off-by: nalbury <nickalbury@gmail.com>
Signed-off-by: Nick Albury <nalbury@handy.com>
Signed-off-by: nalbury <nickalbury@gmail.com>
@nalbury nalbury force-pushed the update-crossplane-runtime-latest branch from 4a1e31b to 5f68421 Compare November 17, 2023 14:17
@nalbury
Copy link
Contributor Author

nalbury commented Nov 17, 2023

Apologies for the force push, had to sign my commits.

Copy link

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turkenh turkenh merged commit 5c90b93 into crossplane-contrib:main Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants