Added Injected Identity Source #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Wadsworth <brad.wadsworth@mavenwave.com>
|
Related code section: |
turkenh
reviewed
Aug 18, 2022
| @@ -95,6 +95,8 @@ func CommonCredentialExtractor(ctx context.Context, source xpv1.CredentialsSourc | |||
| return ExtractFs(ctx, afero.NewOsFs(), selector) | |||
| case xpv1.CredentialsSourceSecret: | |||
| return ExtractSecret(ctx, client, selector) | |||
| case xpv1.CredentialsSourceInjectedIdentity: | |||
There was a problem hiding this comment.
Given we don't have to extract any credentials, in this case, we can check whether the source equals xpv1.CredentialsSourceInjectedIdentity before calling CommonCredentialExtractor.
That approach makes it more explicit regarding the intent.
See this as an example.
|
Decided to only modify provider for InjectedIdentity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brad Wadsworth brad.wadsworth@mavenwave.com
Description of your changes
Add the ability to use InjectedIdentity as a CommonCredentialExtractor option. This will just return a nil value and will rely on the specific provider to take the appropriate action in order to fetch the injected credentials.
Fixes #335
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested with workload identity using a forked helm provider in a google GKE cluster.