This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
add valueFrom AppConfig in depedency requirement #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonderflow
force-pushed
the
dependency
branch
from
0fa9f7a
to
57db591
Compare
Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
wonderflow
force-pushed
the
dependency
branch
from
57db591
to
50605a9
Compare
hongchaodeng
approved these changes
Sep 28, 2020
apis/core/v1alpha2/core_types.go
Outdated
| // +optional | ||
| FieldPath string `json:"fieldPath,omitempty"` | ||
| } | ||
|
|
||
| // ValueFrom get value from AppConfig object by specify a path |
There was a problem hiding this comment.
Suggested change
| // ValueFrom get value from AppConfig object by specify a path | |
| // ValueFrom gets value from AppConfig object by specifying a path |
wonderflow
changed the title
wonderflow
force-pushed
the
dependency
branch
from
e565ff8
to
161c56e
Compare
Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
wonderflow
force-pushed
the
dependency
branch
from
161c56e
to
14f1c2a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one part to fix issue #222