Remove diff calculation in observe-only reconciliation #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergenci
force-pushed
the
remove-diff-in-observe-only
branch
2 times, most recently
from
54e83a3 to
10d0d54
Compare
mergenci
added a commit
to mergenci/provider-aws
that referenced
this pull request
Jan 28, 2025
crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
3 tasks
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
mergenci
force-pushed
the
remove-diff-in-observe-only
branch
from
10d0d54 to
cfc7b7c
Compare
mergenci
added a commit
to mergenci/provider-aws
that referenced
this pull request
Jan 29, 2025
crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
mergenci
requested review from
ulucinar,
sergenyalcin and
erhancagirici
as code owners
mergenci
added a commit
to mergenci/provider-aws
that referenced
this pull request
Jan 29, 2025
crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
mergenci
force-pushed
the
remove-diff-in-observe-only
branch
from
cfc7b7c to
ffee480
Compare
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
mergenci
force-pushed
the
remove-diff-in-observe-only
branch
from
ffee480 to
525abba
Compare
We discovered that GoLand failed to build without the generics expression, whereas VS Code warned that it was unnecessary. Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
mergenci
added a commit
to mergenci/provider-aws
that referenced
this pull request
Jan 30, 2025
Consumed Upjet PRs: - crossplane/upjet#454 - crossplane/upjet#450 - crossplane/upjet#451 - crossplane/upjet#437 - crossplane/upjet#462 - crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes crossplane-contrib/provider-upjet-aws#1597.
While importing a DynamoDB Table, in the linked issue, Terraform executes
CustomizeDifffunctions when Upjet calculates the diff inObserve(). One of theCustomizeDifffunctions is a validation function that checks whether the configuration that is subject to diff is valid. Because the configuration is practically empty — it only contains the resource name in the import path — validation fails and returns an error, which in turn causes ourObserve()to fail.I've checked how the behavior of managed reconciler changes for observe-only reconciliation. When Upjet always returns
ResourceUpToDate = true, this block executes. Otherwise, when Upjet calculates the diff and returnsResourceUpToDateaccordingly, this block executes in caseResourceUpToDate = false. The difference between those two blocks are (1) debug messages and (2) metric records.The difference doesn't matter for the import path, in which
ResourceUpToDatedoesn't make much sense. We can considerResourceUpToDate = true, by definition, which is the case in this PR. The difference might matter in observe-only reconciliation that is not an import operation.I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
I tested manually, using the resource manifest given in the linked issue above. Here are the steps I followed:
deletionPolicy: Orphan.managementPolicies: ["Observe"].status.atProvidertospec.forProvider.managementPolicies: ["*"].In addition to DynamoDB Table, I tested a VPC resource as well.
I also ran Uptests in crossplane-contrib/provider-upjet-aws#1651.