Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export core functionality of uptest #38

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Export core functionality of uptest #38

merged 3 commits into from
Jan 28, 2025

Conversation

sergenyalcin
Copy link
Member

Description of your changes

This PR,

  • turns the core functionality into a library, which can then be used externally. This allows users to integrate into uptest at a lower level.
  • changes to optional (from required) the setup script for the apply step.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@sergenyalcin
Export core functionality of uptest
ab90e15 
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
@sergenyalcin
Remove the setup script requirement for the apply step
e379bca 
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
@sergenyalcin sergenyalcin requested a review from haarchri January 28, 2025 10:39
@sergenyalcin
Add code comments for exported packages
8ede9cd 
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
haarchri
haarchri approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks to make this possible and use as library

jeanduplessis
jeanduplessis approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@jeanduplessis jeanduplessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergenyalcin sergenyalcin merged commit 804bb75 into crossplane:main Jan 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanduplessis jeanduplessis jeanduplessis approved these changes

@haarchri haarchri haarchri approved these changes

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergenyalcin @jeanduplessis @haarchri