-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cscli): add env variable flag for dashboard setup #3110
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Nathanael DEMACON <quantumsheep@users.noreply.github.com>
@quantumsheep: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@quantumsheep: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/area cscli |
/area configuration |
/kind enhancement |
Hey 👋🏻 Thank you for your contribution, we have just feature locked Edit: Ohhh you just saw and closed, we can merge but keep in mind the command will be useable if people want to keep a local cscli binary just for dashboard. |
Ok then I reopen them! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3110 +/- ##
==========================================
- Coverage 49.86% 49.84% -0.02%
==========================================
Files 321 321
Lines 37667 37670 +3
==========================================
- Hits 18781 18776 -5
- Misses 17060 17069 +9
+ Partials 1826 1825 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey!
I'm using nginx-proxy which works by reading the environment variables of a container to generate nginx configuration.
These changes adds a
--env
/-e
option tocscli dashboard setup
. The arguments are then forwarded to the container creation config.Thanks,