Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cscli): add a way to disable port binding in dashboard setup #3111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

quantumsheep
Copy link

Hey!

I don't necessary want to bind the port.

-1 seems fine (0 means random) but if you have another way to disable the port let me know. Another specialized flag maybe?

Thanks,

Signed-off-by: Nathanael DEMACON <quantumsheep@users.noreply.github.com>
Copy link

github-actions bot commented Jul 5, 2024

@quantumsheep: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jul 5, 2024

@quantumsheep: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@quantumsheep
Copy link
Author

/kind enhancement
/area cscli
/area configuration

@quantumsheep
Copy link
Author

@LaurenceJJones
Copy link
Contributor

LaurenceJJones commented Jul 5, 2024

Copy and paste comment just so its on both PR's

Hey 👋🏻 Thank you for your contribution, we have just feature locked 1.6.3 so we will pushed these for 1.6.4. However, note we plan to deprecate the cscli dashboard command as of 1.7.0

@quantumsheep quantumsheep reopened this Jul 5, 2024
Signed-off-by: Nathanael DEMACON <quantumsheep@users.noreply.github.com>
@LaurenceJJones LaurenceJJones added this to the 1.6.4 milestone Jul 5, 2024
@buixor buixor modified the milestones: 1.6.4, 1.6.5 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants