Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context propagation: pass ctx to UpdateScenario() #3258

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 24, 2024

No description provided.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added this to the 1.6.4 milestone Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.32%. Comparing base (3945a99) to head (db2c0bc).

Files with missing lines Patch % Lines
pkg/protobufs/plugin_interface.go 0.00% 2 Missing ⚠️
cmd/crowdsec-cli/clicapi/capi.go 0.00% 0 Missing and 1 partial ⚠️
cmd/crowdsec/lapiclient.go 0.00% 0 Missing and 1 partial ⚠️
pkg/apiclient/auth_jwt.go 66.66% 1 Missing ⚠️
pkg/apiserver/apic_metrics.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3258      +/-   ##
==========================================
- Coverage   51.36%   51.32%   -0.04%     
==========================================
  Files         357      357              
  Lines       38953    38947       -6     
==========================================
- Hits        20008    19991      -17     
- Misses      16985    16993       +8     
- Partials     1960     1963       +3     
Flag Coverage Δ
bats 40.93% <64.70%> (-0.08%) ⬇️
unit-linux 34.73% <53.33%> (-0.03%) ⬇️
unit-windows 28.63% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added the kind/enhancement New feature or request label Sep 24, 2024
@mmetc mmetc marked this pull request as ready for review September 24, 2024 14:26
@mmetc mmetc requested a review from blotus September 25, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant