feat(podAnnotations): individualized Pod Annotations #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthvo
reviewed
Dec 2, 2024
charts/cryostat/values.yaml
Outdated
| @@ -351,7 +363,7 @@ serviceAccount: | |||
| ## @param serviceAccount.name The name of the service account to use. If not set and create is true, a name is generated using the fullname template | |||
| name: "" | |||
|
|
|||
| ## @param podAnnotations [object] Annotations to be applied to the Cryostat Pod | |||
| ## @param podAnnotations [object] Annotations to be applied to the various Pods | |||
There was a problem hiding this comment.
Would it be clearer to say "Common annotations that applied to all managed Pods"?
charts/cryostat/values.yaml
Outdated
| @@ -199,6 +207,8 @@ grafana: | |||
| pullPolicy: Always | |||
| ## @param grafana.image.tag Tag for the Grafana container image | |||
| tag: "latest" | |||
| ## @param grafana.podAnnotations [object] Annotations to be applied to the Grafana Pods | |||
| podAnnotations: {} | |||
There was a problem hiding this comment.
These are unused right? Grafana and Datasource are in the same pod as Cryostat.
charts/cryostat/values.yaml
Outdated
| @@ -229,6 +239,8 @@ datasource: | |||
| pullPolicy: Always | |||
| ## @param datasource.image.tag Tag for the JFR Data Source container image | |||
| tag: "latest" | |||
| ## @param datasource.podAnnotations [object] Annotations to be applied to the JFR Datasource Pods | |||
| podAnnotations: {} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #220
To test:
helm install --set-json 'podAnnotations={"foo":"bar","com.example/annotation":"hello"}' --set-json 'storage.podAnnotations={"alice":"bob"}' cryostat ./charts/cryostathelm install --set-json 'podAnnotations={"foo":"bar"}' --set-json 'core.podAnnotations={"foo":"baz"}' cryostat ./charts/cryostat