fix(pvc): split PVC configuration between Deployments #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthvo
reviewed
Nov 29, 2024
tthvo
reviewed
Nov 30, 2024
andrewazores
force-pushed
the
split-pvc
branch
2 times, most recently
from
6266f47 to
ea48416
Compare
ebaron
reviewed
Apr 7, 2025
ebaron
approved these changes
Apr 8, 2025
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2025
(cherry picked from commit d58a0a2)
andrewazores
added a commit
that referenced
this pull request
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #220
Splits PVC definition in two. Originally, storage only needed to be provided to the Cryostat container itself, for the archives. Later we added the h2:file database in 2.x, which was still part of the Cryostat container. Since Cryostat 3.0 we have a separate database and a separate S3 storage running as separate containers in the same Pod. In 4.0 we have separate Deployments for each of Cryostat, database, and storage. Therefore, it only makes sense that the database and storage have storage configuration parameters (and Cryostat does not), and both of these should also be configured separately since the size and speed requirements for each are likely to differ significantly.