Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): add port to INSIGHTS_PROXY #674

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Nov 9, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Related to: https://github.com/cryostatio/cryostat/issues/1763

Description of the change:

Adds the HTTP port to the INSIGHTS_PROXY environment variable in the Cryostat deployment.

Motivation for the change:

Agents attempt to incorrectly connect to the default port of 80.

@ebaron ebaron requested a review from andrewazores November 9, 2023 21:32
@ebaron ebaron marked this pull request as ready for review November 9, 2023 21:32
@mergify mergify bot added the safe-to-test label Nov 9, 2023
@ebaron
Copy link
Member Author

ebaron commented Nov 9, 2023

/build_test

@ebaron ebaron merged commit 2fc1e3e into cryostatio:main Nov 9, 2023
mergify bot pushed a commit that referenced this pull request Nov 9, 2023
ebaron added a commit that referenced this pull request Nov 9, 2023
(cherry picked from commit 2fc1e3e)

Co-authored-by: Elliott Baron <ebaron@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants