Skip to content

Commit

Permalink
Bugfix: Some smaller fixes (#1995)
Browse files Browse the repository at this point in the history
* delete_wallet_file for non-leaky-abstractions

* delete_wallet_file improvement

* upgrade spectrum to v0.2.4
  • Loading branch information
k9ert authored Dec 6, 2022
1 parent 29c28db commit 6e9e36b
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 4 deletions.
2 changes: 1 addition & 1 deletion requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ pytimeparse==1.1.8
cryptoadvance-liquidissuer==0.2.4
specterext-exfund==0.1.7
specterext-faucet==0.1.2
cryptoadvance.spectrum==0.2.1
cryptoadvance.spectrum==0.2.4
6 changes: 3 additions & 3 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ cryptoadvance-liquidissuer==0.2.4 \
--hash=sha256:5a2c531801854c5a4a46daf184877e22f731cdb42d2cfb840785bda7371ba6fb \
--hash=sha256:9e468f3e35ecc566b3f74a2263677cf26632548abb194521dba15ad37acd1e9b
# via -r requirements.in
cryptoadvance-spectrum==0.2.1 \
--hash=sha256:9152ba7b434186c557d82b9658530a10c36598b1c1706e0ccc68238bb2e42923 \
--hash=sha256:ab61fd99b2c103721ec57705f9ec52fd84e6045c31dfc65732d3ffe2c5235f62
cryptoadvance-spectrum==0.2.4 \
--hash=sha256:0a0c01d22846837e7dbd6c7424290d0c53c0d295787e9862affa63ea9b69c906 \
--hash=sha256:f5e1511994091ea5c29263a5a5e21fc5084775bfd39dd712f302f07d94e75b36
# via -r requirements.in
cryptography==3.4.7 \
--hash=sha256:0f1212a66329c80d68aeeb39b8a16d54ef57071bf22ff4e521657b27372e327d \
Expand Down
10 changes: 10 additions & 0 deletions src/cryptoadvance/specter/node.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,16 @@ def node_connection_template(self):
"""This should return the path to a connection template as string"""
return "includes/sidebar/components/node_connection.jinja"

def delete_wallet_file(self, wallet) -> bool:
"""Deleting the wallet file located on the node. This only works if the node is on the same machine as Specter.
Returns True if the wallet file could be deleted, otherwise returns False.
In the case of an Abtract Node, we consider that method as an edge-case anyway and we just return False here.
That is the normal usage if you don't have access to the internals of your Bitcoin Core.
Overwrite as necessary.
"""
return False


class Node(AbstractNode):
"""A Node represents the connection to a Bitcoin and/or Liquid (Full-) node.
Expand Down

0 comments on commit 6e9e36b

Please sign in to comment.