fix: Modernize CI #2487
Merged
fix: Modernize CI #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows caching if requirements.txt is unchanged
✅ Deploy Preview for specter-desktop-docs canceled.
|
AaronDewes
commented
Jan 3, 2025
Comment on lines
-23
to
+31
| COPY . . | ||
| COPY requirements.txt . | ||
|
|
||
| RUN pip3 install --upgrade pip | ||
| RUN pip3 install babel cryptography | ||
| RUN pip3 install . | ||
| RUN pip3 install -r requirements.txt | ||
|
|
||
| COPY . . | ||
|
|
||
| RUN pip3 install . --no-deps |
There was a problem hiding this comment.
This is the main part of this fix, which is a change in the order deps are installed.
It also makes builds faster as a side effect.
Comment on lines
-12
to
+17
| FROM python:3.10-slim-bullseye AS builder | ||
| FROM python:3.10-bookworm AS builder | ||
|
|
||
| ARG VERSION | ||
| ARG REPO | ||
|
|
||
| RUN apt update && apt install -y git build-essential libusb-1.0-0-dev libudev-dev libffi-dev libssl-dev rustc cargo libpq-dev | ||
| RUN apt update && apt install -y git libusb-1.0-0-dev libudev-dev libffi-dev libssl-dev rustc cargo libpq-dev |
There was a problem hiding this comment.
This is also just a build speed optimization, instead of using the slim image, just use the non-slim image during build, which has most packages we need for building preinstalled.
Comment on lines
+42
to
+43
| --cache-from type=gha \ | ||
| --cache-to type=gha,mode=max \ |
There was a problem hiding this comment.
This enables caching.
moneymanolis
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This