Fix OptionParser subcommand help to respect custom summary_indent #16334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kojix2
commented
Nov 6, 2025
| help.should eq <<-USAGE | ||
| Usage: foo subcommand | ||
| ||--help Help | ||
| ||--local Local flag |
Contributor
Author
There was a problem hiding this comment.
Note on Flag Ordering
In the help output, common flags like --help appear before subcommand-specific flags like --local. This happens because OptionParser shows flags in the order they are registered.
This may not be the best user experience, but fixing the flag order is not part of this PR.
Blacksmoke16
added
kind:bug
straight-shoota
approved these changes
Nov 21, 2025
ysbaddaden
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
This PR fixes a bug in
OptionParser#handle_flagwhere subcommand help output did not respect customsummary_indentsettings.This change only affects help message formatting (to_s output)