Add boolean flags to OptionParser
#16370
Open
+124
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an options. OptionParser doesn't have --no- and --[no-] options so I added them. feature: single --no- switch added to OptionParser to set an option to false. feature: optional --[no-] switch added to OptionParser for true/false options. style: reformatted some OptionParser regex for readability/comparability. test: specs for OptionParser boolean options added. docs: Added docs for `OptionParser#bool` and updated `OptionParser#on`.
andrykonchin
force-pushed
the
ak/add-no-to-optionparser
branch
from
67a9935 to
3aacbf9
Compare
Contributor
Author
|
It seems that this feature is an edge case of type coercion that requires adding some new abstractions. This implementation seems very fast and dirty. |
Contributor
Author
|
I've noticed a minor difference in handling |
Member
|
Instead of adding a new handler type, maybe we could just wrap the bool handler in a regular one? We could encode Handler.new(value_type) do |value|
block.call(value == "true")
endThis could keep everything a bit simpler, I hope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
OptionParser#13726Supersedes #13726 and closes #13719