Add Sync::Mutex and Sync::RWLock
#16399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
commented
Nov 21, 2025
This is the foundation type for building the actual Mutex and RWLock types that add some runtime checks (who owns the lock), reentrancy.
ysbaddaden
force-pushed
the
feature/import-sync-mutex-and-rwlock
branch
from
1aa9d97 to
4dc5456
Compare
Contributor
Author
|
I forgot to update |
straight-shoota
approved these changes
Nov 25, 2025
straight-shoota
changed the title
Sync::Mutex and Sync::RWLock from the sync shardSync::Mutex and Sync::RWLock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types are copy-pasted from the sync shard, minus
Sync::Dll(T)that is replaced byCrystal::PointerLinkedList(T)(main difference is that dll nodes are circular lists, maybe a bit simpler), andSync::Lockablethat will come in a follow-up PR to importSync::ConditionVariable.I kept the
Syncnamespace as it will be useful to group many different sync objects, rather than adding more and more types at the top level.The PR doesn't deprecate nor remove
::Mutex(yet). That will come in a follow up.