-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix Crystal::Target#unix? to consider android
#16403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Crystal::Target#unix? to consider android
#16403
Conversation
|
I think we ought to fix |
|
We usually leave normalization to This PR is just a simple fix to make the |
|
LLVM sees |
|
Yes, we can fix this particular problem from the other end as well 👍 That moves |
|
Superseded by #16409 |
|
Oh, but |
|
It's an error IMO. It shall return |
`aarch64-linux-android` is the canonical name (#16403 (comment)).
aarch64-linux-androidcurrently gets theunixflag, because oflinux. But the aliasaarch64-androiddoes not containlinux...