Simplify shutdown handling for graceful cleanup #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplify the shutdown handling by replacing complex signal-based shutdown with a cleaner try/finally approach.
Problem
The previous implementation used custom signal handlers that called
sys.exit()from async code, which could cause:Solution
sys.exit()from async codemain()to ensurecleanup()is always calledKeyboardInterruptin__init__.pyto suppress traceback on Ctrl+Casyncio,signal,sys) from server.pyshutdown()tocleanup()to reflect its simpler purposeThis approach:
Attribution
Based on work by @ahmedmustahid in #78. This PR extracts and simplifies just the shutdown handling portion.
Test plan
🤖 Generated with Claude Code