Add instruction offsets to simplify source mapping #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instructions can be addressed using either the program counter or instruction offsets. The source maps generated by the Solidity compiler use instruction offsets. This PR makes the offset an optional property of a disassembled instruction to simplify working with source maps.
Quoting from the linked docs:
Background
We're developing a Solidity debugger that uses Pyevmasm as a disassembler. We heavily use source maps, and by adding support for instruction offsets directly to Pyevmasm, we can safely switch between the two addressing schemes. Other developer tools might also profit from this change.