Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of CI tests on PR #2572

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Reduce the number of CI tests on PR #2572

merged 4 commits into from
Oct 3, 2024

Conversation

montyly
Copy link
Member

@montyly montyly commented Oct 2, 2024

Everything is still run on a daily basis with cron, but this PR remove unecessary/problematic CI checks on every PR

Everything is still run on a daily basis with cron, but this PR remove unecessary/problematic CI checks on every PR
@montyly montyly requested a review from elopez as a code owner October 2, 2024 12:36
@elopez
Copy link
Member

elopez commented Oct 2, 2024

Can this be done without duplicating the workflow? See e.g. how we do to differenciate the python versions between PRs and other runs

python: ${{ (github.event_name == 'pull_request' && fromJSON('["3.8", "3.12"]')) || fromJSON('["3.8", "3.9", "3.10", "3.11", "3.12"]') }}

@montyly
Copy link
Member Author

montyly commented Oct 2, 2024

@elopez : maybe?

I do think that in the long term, we will likely have two different sets of tests for the ones we run on every PR and the ones we run through the cron.

Right now, there is an intersection, but most likely, we don't need that once we have a better testing structure.

@montyly montyly merged commit 0811cd6 into dev Oct 3, 2024
41 checks passed
@montyly montyly deleted the improve-CI branch October 3, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants