Implement ApiClient for all endpoints #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mads256h
force-pushed
the
frontend-backend-test
branch
7 times, most recently
from
f55ff3a
to
3a6ccc4
Compare
Change delete endpoints to only take the id of the object to delete. Change delete endpoints to use the HTTP DELETE method. Add protocol objects to the frontend for talking to the backend. Use kotlin coroutines instead of callbacks for the ApiClient. Create tests that connect to http://localhost:3000 and tests with the backend.
mads256h
force-pushed
the
frontend-backend-test
branch
from
3a6ccc4
to
cf74d68
Compare
Mikkel-Boje
approved these changes
Apr 5, 2024
|
|
||
| #[derive(Deserialize, Serialize)] | ||
| pub struct DeleteDeviceRequest { | ||
| pub id: i64, |
There was a problem hiding this comment.
Is this the device' id?
There was a problem hiding this comment.
Yes it matches the name in the device struct
|
|
||
| #[derive(Deserialize, Serialize)] | ||
| pub struct DeleteTaskRequest { | ||
| pub id: i64, |
There was a problem hiding this comment.
Yes it matches the name in the task struct
S3JER
approved these changes
Apr 5, 2024
Darkros1245
approved these changes
Apr 5, 2024
frontend/app/src/test/java/dk/scheduling/schedulingfrontend/ApiServiceTest.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change delete endpoints to only take the id of the object to delete. Change delete endpoints to use the HTTP DELETE method.
Add protocol objects to the frontend for talking to the backend. Use kotlin coroutines instead of callbacks for the ApiClient.
Create tests that connect to http://localhost:3000 and tests with the backend.