Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in SP23 Main #20

Merged
merged 126 commits into from
Mar 8, 2024
Merged

Merge in SP23 Main #20

merged 126 commits into from
Mar 8, 2024

Conversation

cycomachead
Copy link
Member

TODO: Let's get this PR up to spec!

@warrenlet warrenlet closed this Feb 18, 2024
@warrenlet warrenlet reopened this Feb 18, 2024
@warrenlet warrenlet force-pushed the sp23-main branch 2 times, most recently from 1837c3b to cf5fcb1 Compare February 18, 2024 06:13
Copy link

@warrenlet warrenlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Clean up the README: delete the previous semester’s badges
  • Delete non-use readme
  • Add a helper function to Admin/tickets
  • Update host variable in email_template_parsr
  • Other minor fix

@warrenlet
Copy link

warrenlet commented Feb 18, 2024

  • .codeclimate.yml's channel is updated to rubocop-1-56-3
  • Couldn't resolve codeclimate issues because codeclimate uses Ruby version up tp 2.7. Our repo Ruby version is 3.2.
  • See details in codeclimate

update: set up rubocop-1-56-3 in branch sp23 main won't update to codeclimate site. I update the rubocop-1-48-1 to main branch and now the codeclimate error is gone.
Also need to fix the remaining issues from codeclimate code check

@warrenlet warrenlet merged commit fcb1f10 into main Mar 8, 2024
14 of 16 checks passed
@cycomachead
Copy link
Member Author

Nice, thank you! :D

@cycomachead cycomachead deleted the sp23-main branch August 1, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants