187057653 fix "edit profile" shows admin and confirmed toggles as a non-admin #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ofile-admin-toggle
Edge7481
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.Short description of what this resolves/which issues does this fix?:
A non-admin is currently able to see the "is admin" and "confirmed" toggles via edit profile. Interacting with it does not do anything for both admin and non-admins.
administration->users->edit renders views/admin/users/edit.html.haml, whereas edit profile renders views/users/edit.html.haml. The former is working as intended.
Changes proposed in this pull request:
Makes it such that no user (admins, non-admins) can see these toggles. An admin is still able to change these settings by going to administration->users->edit. The button for admin has also been updated from a checkbox to a toggle switch.