Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

187121440 materials bulk upload #28

Merged
merged 4 commits into from
Apr 15, 2024
Merged

187121440 materials bulk upload #28

merged 4 commits into from
Apr 15, 2024

Conversation

warrenlet
Copy link

@warrenlet warrenlet commented Mar 19, 2024 •
edited by fp456
Loading

Pivotal Tracker Link

What this PR does:

This pull request fixes|implements (pick one...) ______.

Include screenshots, videos, etc.

Who authored this PR?

How should this PR be tested?

  • Is there a deploy we can view?
  • What do the specs/features test?
  • Are there edge cases to watch out for?

Are there any complications to deploying this?

Checklist:

  • Has this been deployed to a staging environment or reviewed by a customer?
  • Tag someone for code review (either a coach / team member)
  • I have renamed the branch to match PivotTracker's suggested one (necessary for BlueJay)

@Edge7481
Copy link

Edge7481 commented Apr 1, 2024

Would it be possible to write a few tests that checks the csv is working

fp456
fp456 suggested changes Apr 4, 2024
View reviewed changes
Copy link

@fp456 fp456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it'll be possible to add some tests for the code added. Also, please update the PR template with the given info, thank you!

@warrenlet warrenlet merged commit adc8282 into main Apr 15, 2024
16 checks passed
@cycomachead cycomachead deleted the 187121440_Materials_Bulk_Upload branch August 1, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cycomachead cycomachead cycomachead left review comments

@fp456 fp456 fp456 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@warrenlet @Edge7481 @cycomachead @fp456