Add convert currency and tests #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fp456
reviewed
Apr 4, 2024
| if conversion | ||
| Money.add_rate(from_currency, to_currency, conversion.rate) | ||
| amount.exchange_to(to_currency) | ||
| else |
There was a problem hiding this comment.
Maybe consider returning -1 instead instead of returning an amount without conversion. Whenever you use this method convert_currency, you can check for the amount not being -1
There was a problem hiding this comment.
if you choose this path, remember to update the tests below
fp456
approved these changes
Apr 4, 2024
Edge7481
force-pushed
the
187348127-add-convert-currency
branch
from
c3d0322 to
6923177
Compare
|
Updated the bad path to -1 now. Should work better for validation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pivotal Tracker Link
What this PR does:
This pull request implements
a static method in Currency_Conversion.rb that converts a Money object of a currency to a Money object of another currency, since as of right now there's no functionality to actually convert. It will be used to compute payments later
Include screenshots, videos, etc.
N/A
Who authored this PR?
How should this PR be tested?
I added 2 tests that tests the path that there is a valid currency in the table, and the path the there is no currency in the table.
Are there any complications to deploying this?
No
Checklist: