Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pkg_resources with importlib.metadata for Python 3.12 #116

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Replace pkg_resources with importlib.metadata for Python 3.12 #116

merged 7 commits into from
Jul 8, 2024

Conversation

rongxin-liu
Copy link
Contributor

This PR addresses #115

@rongxin-liu rongxin-liu self-assigned this Nov 19, 2023
@dmalan
Copy link
Member

dmalan commented Nov 19, 2023

Also used a couple other places:

cli50/cli50/__main__.py

Line 38 in a420ffe

t = gettext.translation("cli50", pkg_resources.resource_filename("cli50", "locale"), fallback=True)

cli50/cli50/__main__.py

Line 64 in a420ffe

release = max(requests.get("https://pypi.org/pypi/cli50/json").json()["releases"], key=pkg_resources.parse_version)

rongxin-liu
rongxin-liu commented Jul 8, 2024
View reviewed changes
Copy link
Contributor Author

@rongxin-liu rongxin-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging!

@rongxin-liu rongxin-liu merged commit 8ae5e0e into main Jul 8, 2024
1 check passed
@rongxin-liu rongxin-liu deleted the rongxin-patch-1 branch July 8, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rongxin-liu rongxin-liu

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rongxin-liu @dmalan