Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pset4] [recover] Add hashes for jpeg files without trailing zeros #243

Open
wants to merge 2 commits into
base: 2024/x
Choose a base branch
from

Conversation

RCW679
Copy link

@RCW679 RCW679 commented May 11, 2024

I wrote Recover from pset4 in such a way that it would actually parse the jpeg headers and look for EOI (FF D9), and stop there. This means that my implementation doesn't save the trailing zeros after EOI -- only to realize that the check50 checks failed with 'recovered image does not match', even though the actual content in the JPEG was the same. I then went to the checks and realized that it was using hashes of JPEG files with the trailing zeros. I then wrote a new Recover in such a way that it preserved the trailing zeros, and the checks passed.

The modifications in this PR add the hashes of the JPEG files without trailing zeros, while preserving the hashes of the JPEG files with the zeros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant