Adds extra check for Plurality #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extra check makes sure that only the winner's name is printed out, even if the two losers tied 1-1.
See proposed changes to __init__.py.
changes merge
|
Unless I see the "hack-around" code and it changes my mind, I see minimal value in this PR. Though for complete thoroughness, it is not a bad quick change to make. Still, a whole new case is unnecessary. Simply just change one of the loser's amount of votes in a print_winner function to match the other loser. For example, I would just change line 84 in testing.c to candidates[2].votes = 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extra check ensures that only the winner's name is printed, even if the losers tied, thus preventing some hack around logic, such as can be seen on my first check50 submission of the problem as an example.