Skip to content

Commit

Permalink
Merge pull request #146 from cs50/develop
Browse files Browse the repository at this point in the history
handles slugs that have unexpected leading or trailing slashes
  • Loading branch information
dmalan authored Sep 29, 2017
2 parents c97f9a2 + 6225df1 commit 22c62c6
Show file tree
Hide file tree
Showing 4 changed files with 58 additions and 37 deletions.
87 changes: 51 additions & 36 deletions locale/es/LC_MESSAGES/messages.po
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
msgid ""
msgstr ""
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-09-18 16:09+0000\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"

Expand All @@ -8,96 +10,109 @@ msgid "You have an old version of python. Install version 2.7 or higher."
msgstr ""
"Tienes una versión antigua de python. Instala la versión 2.7 o superior."

#: submit50.py:116
#: submit50.py:119
msgid "show commands being executed"
msgstr "mostrar comandos que se están ejecutando"

#: submit50.py:117
#: submit50.py:120
msgid "prescribed identifier of work to submit"
msgstr "identificador prescrito del trabajo para entregar"

#: submit50.py:177
#: submit50.py:182
msgid "GitHub username: "
msgstr "Nombre de usuario de GitHub: "

#: submit50.py:185
#: submit50.py:190
msgid "GitHub password: "
msgstr "Contraseña de GitHub: "

#: submit50.py:225
#: submit50.py:230
msgid "Invalid username and/or password."
msgstr "Nombre de usuario y/o contraseña es inválido."

#: submit50.py:229
#: submit50.py:234
msgid "Could not authenticate user."
msgstr "No se pudo autenticar usuario."

#: submit50.py:282
#: submit50.py:288
msgid "Could not connect to GitHub."
msgstr "No se pudo conectar a GitHub."

#: submit50.py:286
#: submit50.py:292
msgid "Sorry, something's wrong! Let sysadmins@cs50.harvard.edu know!"
msgstr "¡Lo siento, algo está mal! ¡Déjale saber a sysadmins@cs50.harvard.edu!"

#: submit50.py:292 submit50.py:309
#: submit50.py:298 submit50.py:316
msgid "Submission cancelled."
msgstr "La entrega se canceló."

#: submit50.py:409
#: submit50.py:422
msgid "You don't have git. Install git, then re-run {}!"
msgstr "No tienes git. ¡Instala git, y luego vuelve a ejecutar {}!"

#: submit50.py:413
#: submit50.py:427
msgid ""
"You have an old version of git. Install version 2.7 or later, then re-run {}!"
msgstr ""
"Tienes una versión antigua de git. ¡Instala la versión 2.7 o superior, y "
"vuelve a ejecutar {}!"

#: submit50.py:427
#: submit50.py:441
msgid ""
"You have an unknown version of submit50. Email sysadmins@cs50.harvard.edu!"
msgstr ""
"Tienes una versión desconocida de submit50. ¡Escríbele a sysadmins@cs50."
"harvard.edu!"

#: submit50.py:431
#: submit50.py:445
msgid "You have an old version of submit50. Run update50, then re-run {}!"
msgstr ""
"Tienes una versión antigua de submit50. ¡Ejecuta update50, y luego vuelve a "
"ejecutar {}!"

#: submit50.py:451
#: submit50.py:465
msgid "Invalid slug. Did you mean to submit something else?"
msgstr "El slug no es válido. ¿Quisiste entregar algo más?"

#: submit50.py:467
#: submit50.py:469
msgid ""
"Invalid slug. Did you mean {}, without the leading and trailing slashes?"
msgstr "El slug no es válido. ¿Querías decir {}, sin las barras la barra "
"diagonal principal y la barra diagonal final?"

#: submit50.py:471
msgid "Invalid slug. Did you mean {}, without the leading slash?"
msgstr "El slug no es válido. ¿Querías decir {}, sin la barra diagonal principal?"

#: submit50.py:473
msgid "Invalid slug. Did you mean {}, without the trailing slash?"
msgstr "El slug no es válido. ¿Querías decir {}, sin la barra diagonal al final?"

#: submit50.py:487
msgid "You seem to be missing these files:"
msgstr "Parece que faltan estos archivos:"

#: submit50.py:470
#: submit50.py:490
msgid "Ensure you have the required files before submitting."
msgstr "Asegúrate de tener los archivos necesarios antes de entregar."

#: submit50.py:473
#: submit50.py:493
msgid "Authenticating"
msgstr "Autenticando"

#: submit50.py:499
#: submit50.py:520
msgid "Preparing"
msgstr "Preparando"

#: submit50.py:506
#: submit50.py:528
msgid ""
"Looks like {} isn't enabled for your account yet. Log into https://cs50.me/ "
"in a browser, click \"Authorize application\", and re-run {} here!"
"Looks like {} isn't enabled for your account yet. Go to https://cs50.me/"
"authorize and make sure you accept any pending invitations!"
msgstr ""
"Parece que {} todavía no está habilitado para tu cuenta. ¡Inicie sesión en "
"https://cs50.me/ en un navegador, haga clic en \"Authorize application\", y "
"vuelve a ejecutar {} aquí!"
"Parece que {} todavia no esta habilitado en tu cuenta. Visita https://cs50."
"me/authorize y asegúrate de aceptar las invitaciones pendientes!"

#: submit50.py:509
#: submit50.py:531
msgid ""
"Looks like you have the wrong username in ~/.gitconfig or {} isn't yet "
"enabled for your account. Double-check ~/.gitconfig and then log into "
Expand All @@ -109,7 +124,7 @@ msgstr ""
"ingresa en https://cs50.me/ en un navegador, haga clic en \"Authorize "
"application\" si se te solicita, y vuelve a ejecutar {} aquí."

#: submit50.py:557
#: submit50.py:579
msgid ""
"These files are too large to be submitted:\n"
"{}\n"
Expand All @@ -119,7 +134,7 @@ msgstr ""
"{}\n"
"¡Quita estos archivos de tu directorio y luego vuelve a ejecutar: {}!"

#: submit50.py:562
#: submit50.py:584
msgid ""
"These files are too large to be submitted:\n"
"{}\n"
Expand All @@ -131,42 +146,42 @@ msgstr ""
"Instala git-lfs (o quita estos archivos de tu directorio) y luego vuelve a "
"ejecutar {}!"

#: submit50.py:573
#: submit50.py:595
msgid "No files in this directory are expected for submission."
msgstr "Ningún archivo en este directorio se espera para la entrega."

#: submit50.py:578
#: submit50.py:600
msgid "Files that will be submitted:"
msgstr "Archivos que se van a entregar:"

#: submit50.py:584
#: submit50.py:606
msgid "Files that won't be submitted:"
msgstr "Archivos que no se van a entregar:"

#: submit50.py:590
#: submit50.py:612
msgid ""
"Keeping in mind the course's policy on academic honesty, are you sure you "
"want to submit these files (yes/no)? "
msgstr ""
"Teniendo en cuenta la política de honestidad académica del curso, ¿estás "
"seguro que quieres enviar estos archivos (yes/no)? "

#: submit50.py:596
#: submit50.py:618
msgid "No files were submitted."
msgstr "No se ha entregado ningún archivo."

#: submit50.py:600
#: submit50.py:622
msgid "Submitting"
msgstr "Entregando"

#: submit50.py:602
#: submit50.py:624
msgid "Uploading"
msgstr "Subiendo"

#: submit50.py:611
#: submit50.py:633
msgid "Submitted {}! See https://cs50.me/submissions."
msgstr "¡Se entregó {}! Puedes ver https://cs50.me/submissions."

#: submit50.py:660
#: submit50.py:682
msgid "Could not complete two-factor authentication."
msgstr "No se pudo completar la autenticación de dos factores."
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,5 @@ class CustomInstall(install):
"console_scripts": ["submit50=submit50:main"]
},
url="https://github.com/cs50/submit50",
version="2.4.3"
version="2.4.4"
)
6 changes: 6 additions & 0 deletions submit50.py
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,12 @@ def submit(org, branch):
e = Error(_("Invalid slug. Did you mean to submit something else?"))
e.__cause__ = None
raise e
if slug.startswith("/") and slug.endswith("/"):
raise Error(_("Invalid slug. Did you mean {}, without the leading and trailing slashes?".format(slug.strip("/"))))
elif slug.startswith("/"):
raise Error(_("Invalid slug. Did you mean {}, without the leading slash?".format(slug.strip("/"))))
elif slug.endswith("/"):
raise Error(_("Invalid slug. Did you mean {}, without the trailing slash?".format(slug.strip("/"))))

# check for missing files
missing = []
Expand Down
Empty file removed tmp/hello.c
Empty file.

0 comments on commit 22c62c6

Please sign in to comment.