Fix site #1001
Merged
Fix site #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmi4er4
approved these changes
May 26, 2025
cin-bun
added a commit
to cin-bun/lms
that referenced
this pull request
May 27, 2025
* fix: getting site id from settings not request * fix: site id * fix: tests * fix: arc * fix: cr * fix: cr # Checklist: - [ ] The **ticket number** is indicated in the comments - [ ] Unrelated code has been removed **(unused imports, `print` statements, unrelated template context variables, commented code, etc)** - [ ] I **translated the new messages** and added only the .po files that actually changed. - [ ] If there were **changes in the frontend**, there is a PR in the front repository. --- - [ ] I have added **tests** that prove my code works - [ ] No common performance issues **(e.g. N + 1 problem)**
cin-bun
added a commit
that referenced
this pull request
May 27, 2025
* fix: getting site id from settings not request * fix: site id * fix: tests * fix: arc * fix: cr * fix: cr # Checklist: - [ ] The **ticket number** is indicated in the comments - [ ] Unrelated code has been removed **(unused imports, `print` statements, unrelated template context variables, commented code, etc)** - [ ] I **translated the new messages** and added only the .po files that actually changed. - [ ] If there were **changes in the frontend**, there is a PR in the front repository. --- - [ ] I have added **tests** that prove my code works - [ ] No common performance issues **(e.g. N + 1 problem)**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
printstatements, unrelated template context variables, commented code, etc)