Support optional filters in yaml config #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation of the yaml config indicates that the filter list is optinal. If the list was not provided, no tracks were returned as we didn't append the track since there was no match. A default of name with ".*" is now set if not other filter is present. The tests were updated to cover the new behaviour. Additionally, the filter types were updated in the tests to match the supported filters in provider.go.
jusleg
changed the title
Owner
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋 I just discovered this repo thanks to @martelogan. It's great and saved me a lot of time trying to figure out how to make the remux work.
When trying to setup the server based on the readme, I tried to remove the filters configuration and expected it to return all tracks but no tracks were returned. It looks like the track building part assumed the presence of filters. I added a default in the config to set
{Value: ".*", Type: "name"}when trying to compile the regexes and no filters are provided. This will return all the tracks.While updating the tests, I also updated the filter types in the valid configuration to match the filter types expected in provider.go