Add Spec for EncryptionKeyRotation by black-dragon74 · Pull Request #65 · csi-addons/spec

black-dragon74 · 2024-05-23T11:07:49Z

This patch adds specification for EncryptionKeyRotation operation of CSI addons.

black-dragon74 · 2024-06-10T08:06:01Z

@Madhu-1 @Rakshith-R requesting your reviews.

Regards

encryptionkeyrotation/README.md

Makefile

encryptionkeyrotation/README.md

nixpanic · 2024-06-11T14:30:56Z

There are a few failures in the CI jobs, please correct them as well.

Note that encryptionkeyrotation/encryptionkeyrotation.proto is generated from the README.md, and should not be modified manually.

nixpanic · 2024-06-11T14:31:42Z

Also, code under lib/go is generated as well, it should be included in this PR too.

black-dragon74 · 2024-06-11T14:45:41Z

Also, code under lib/go is generated as well, it should be included in this PR too.

It is included in this PR. No?

black-dragon74 · 2024-06-11T14:50:16Z

Note that encryptionkeyrotation/encryptionkeyrotation.proto is generated from the README.md, and should not be modified manually.

I get the cause of the ci-failures. It has to do with me using different proto* set of tools for generating these files. There is a version mismatch. I will send a PR to add support for building on mac. Do we have to use versions as defined in makefile? If so, darwin builds for those specific versions are not available.

If we decide not to support mac, I can build it in docker and then send the PR. (Really hope that we support it though, will make things seamless, IMO)

Regards

nixpanic · 2024-06-11T14:59:48Z

Also, code under lib/go is generated as well, it should be included in this PR too.

It is included in this PR. No?

Oh, yes, they are. I somehow missed them earlier.

nixpanic · 2024-06-11T15:02:00Z

Note that encryptionkeyrotation/encryptionkeyrotation.proto is generated from the README.md, and should not be modified manually.

I get the cause of the ci-failures. It has to do with me using different proto* set of tools for generating these files. There is a version mismatch. I will send a PR to add support for building on mac. Do we have to use versions as defined in makefile? If so, darwin builds for those specific versions are not available.

Within a container (prefer Podman over Docker) should work for sure. I don't know to run that on a Mac though.

If we decide not to support mac, I can build it in docker and then send the PR. (Really hope that we support it though, will make things seamless, IMO)

Sure, that would be nice to have.

black-dragon74 · 2024-06-13T07:35:06Z

The linter is failing due to 403 (unable to access GH Status API), unrelated to this patch.

nixpanic · 2024-06-13T08:35:45Z

The linter is failing due to 403 (unable to access GH Status API), unrelated to this patch.

I do not think the 403 error is critical, that is only failing to provide detailed status updates in the GitHub CI jobs list. If you check the actual failure, you see issues in the .proto linter:

black-dragon74 · 2024-06-13T09:18:07Z

you see issues in the .proto linter

We indent with 2 spaces in proto 🫨? Lesson learned.

Regards

identity/identity.proto

encryptionkeyrotation/README.md

identity/README.md

black-dragon74 · 2024-06-20T10:16:56Z

@Madhu-1 can we get this merged?

Madhu-1

small nits

encryptionkeyrotation/README.md

identity/identity.proto

Madhu-1

LGTM, please squash the commits into 1.

Rakshith-R

Looks good to me.
@nixpanic can you please review again ?

encryptionkeyrotation/README.md

Pull request has been modified.

nixpanic

Thanks!

black-dragon74 · 2024-06-27T09:18:29Z

@Mergifyio refresh

mergify · 2024-06-27T09:18:32Z

refresh

✅ Pull request refreshed

Madhu-1 · 2024-06-27T09:31:14Z

@Mergifyio rebase

This patch adds specification for EncryptionKeyRotation operation of CSI addons. Signed-off-by: Niraj Yadav <niryadav@redhat.com>

mergify · 2024-06-27T09:31:23Z

rebase

✅ Branch has been successfully rebased

mergify bot added the design Adds or updates an operation or service label May 23, 2024

black-dragon74 changed the title ~~Add Spec for EncryptionKeyRotation~~ [WIP] Add Spec for EncryptionKeyRotation May 23, 2024

black-dragon74 changed the title ~~[WIP] Add Spec for EncryptionKeyRotation~~ Add Spec for EncryptionKeyRotation Jun 10, 2024

Rakshith-R reviewed Jun 10, 2024

View reviewed changes

encryptionkeyrotation/README.md Outdated Show resolved Hide resolved

encryptionkeyrotation/README.md Show resolved Hide resolved

nixpanic reviewed Jun 11, 2024

View reviewed changes

encryptionkeyrotation/README.md Outdated Show resolved Hide resolved

black-dragon74 force-pushed the pv-key-rotate branch from ab39503 to 86ce15c Compare June 13, 2024 07:28

black-dragon74 force-pushed the pv-key-rotate branch from 64d6d75 to b13d4fc Compare June 13, 2024 09:15

nixpanic reviewed Jun 13, 2024

View reviewed changes

identity/identity.proto Show resolved Hide resolved

Madhu-1 reviewed Jun 13, 2024

View reviewed changes

identity/identity.proto Show resolved Hide resolved

identity/identity.proto Outdated Show resolved Hide resolved

encryptionkeyrotation/README.md Outdated Show resolved Hide resolved

identity/README.md Show resolved Hide resolved

Madhu-1 reviewed Jun 20, 2024

View reviewed changes

encryptionkeyrotation/README.md Outdated Show resolved Hide resolved

identity/identity.proto Outdated Show resolved Hide resolved

Madhu-1 requested review from Rakshith-R and nixpanic June 20, 2024 10:40

black-dragon74 force-pushed the pv-key-rotate branch from a7f3681 to b3f99fa Compare June 20, 2024 10:51

black-dragon74 requested a review from Madhu-1 June 20, 2024 11:32

Madhu-1 reviewed Jun 20, 2024

View reviewed changes

black-dragon74 force-pushed the pv-key-rotate branch from b3f99fa to 1d7c507 Compare June 20, 2024 11:47

Rakshith-R requested a review from Madhu-1 June 21, 2024 07:18

Rakshith-R reviewed Jun 21, 2024

View reviewed changes

Madhu-1 previously approved these changes Jun 21, 2024

View reviewed changes

nixpanic reviewed Jun 21, 2024

View reviewed changes

encryptionkeyrotation/README.md Outdated Show resolved Hide resolved

encryptionkeyrotation/README.md Outdated Show resolved Hide resolved

encryptionkeyrotation/README.md Show resolved Hide resolved

black-dragon74 mentioned this pull request Jun 25, 2024

Implement EncryptionKeyRotation spec ceph/ceph-csi#4690

Merged

black-dragon74 force-pushed the pv-key-rotate branch from 1d7c507 to 1407a34 Compare June 25, 2024 12:54

black-dragon74 requested a review from nixpanic June 25, 2024 12:55

nixpanic approved these changes Jun 27, 2024

View reviewed changes

Madhu-1 approved these changes Jun 27, 2024

View reviewed changes

Add Spec for EncryptionKeyRotation

2cfec1d

This patch adds specification for EncryptionKeyRotation operation of CSI addons. Signed-off-by: Niraj Yadav <niryadav@redhat.com>

Madhu-1 force-pushed the pv-key-rotate branch from 1407a34 to 2cfec1d Compare June 27, 2024 09:31

mergify bot merged commit 0dd74d5 into csi-addons:main Jun 27, 2024

Conversation

black-dragon74 commented May 23, 2024

Uh oh!

black-dragon74 commented Jun 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nixpanic commented Jun 11, 2024

Uh oh!

nixpanic commented Jun 11, 2024

Uh oh!

black-dragon74 commented Jun 11, 2024

Uh oh!

black-dragon74 commented Jun 11, 2024

Uh oh!

nixpanic commented Jun 11, 2024

Uh oh!

nixpanic commented Jun 11, 2024

Uh oh!

black-dragon74 commented Jun 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nixpanic commented Jun 13, 2024

Uh oh!

black-dragon74 commented Jun 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

black-dragon74 commented Jun 20, 2024

Uh oh!

Madhu-1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Madhu-1 left a comment

Choose a reason for hiding this comment

Uh oh!

Rakshith-R left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nixpanic left a comment

Choose a reason for hiding this comment

Uh oh!

black-dragon74 commented Jun 27, 2024

Uh oh!

mergify bot commented Jun 27, 2024

✅ Pull request refreshed

Uh oh!

Madhu-1 commented Jun 27, 2024

Uh oh!

mergify bot commented Jun 27, 2024

✅ Branch has been successfully rebased

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

black-dragon74 commented Jun 13, 2024 •

edited

Loading