ci(mergify): upgrade configuration to current format #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Madhu-1
approved these changes
Nov 21, 2024
nixpanic
requested changes
Nov 21, 2024
.github/mergify.yml
Outdated
| - check-success=test-lint | ||
| - check-success=test-protoc | ||
| - base~=^(main)|(release-.+)$ | ||
| - label=design |
There was a problem hiding this comment.
this queue_conditions does not look right. It has both
label!=designlabel=design
base is 2x in the list as well as others.
.github/mergify.yml
Outdated
| @@ -65,3 +85,7 @@ pull_request_rules: | |||
| request_reviews: | |||
| users_from_teams: | |||
| - "@csi-addons/maintainers" | |||
| - name: refactored queue action rule | |||
There was a problem hiding this comment.
This rule really confuses me. It might be correct to try-and-queue everything, and remove things from the queue if queue_conditions are not met. But I think it could be written in an easier to understand way (or with extra comments).
mergify
bot
force-pushed
the
mergify/configuration-deprecated-update
branch
from
36e1aa4 to
a213e27
Compare
mergify
bot
force-pushed
the
mergify/configuration-deprecated-update
branch
from
a213e27 to
e3fbfee
Compare
nixpanic
requested changes
Nov 28, 2024
| @@ -65,3 +85,8 @@ pull_request_rules: | |||
| request_reviews: | |||
| users_from_teams: | |||
| - "@csi-addons/maintainers" | |||
| - name: design changes needs approval from at least one core maintainer + merge | |||
There was a problem hiding this comment.
I still don't understand this rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! 👋
We've noticed that your Mergify configuration is using some deprecated fields.
No worries—we've got your back! This automated PR updates your config to align with the newest standards, ensuring everything keeps running smoothly.
Do not procrastinate! You must upgrade your configuration before 2025-01-31, otherwise your configuration will stop working.
What's Changed?
pull_request_rules → actions → queue → update_method: To ease the configuration of queues, we are moving this attribute in thequeue_rulesdefinition. (deadline: 2025-01-31)pull_request_rules → actions → queue → merge_method: To ease the configuration of queues, we are moving this attribute in thequeue_rulesdefinition. (deadline: 2025-01-31)defaults → actions → queue → update_method: To ease the configuration of queues, we are moving this attribute in thequeue_rulesdefinition. (deadline: 2025-01-31)defaults → actions → queue → merge_method: To ease the configuration of queues, we are moving this attribute in thequeue_rulesdefinition. (deadline: 2025-01-31)Why This Matters
Keeping your configuration up-to-date means you'll benefit from the latest features and improvements Mergify has to offer. Plus, it helps prevent any unexpected hiccups down the road.
Got Questions? We've Got Answers! 🙌
Is this update safe to merge?
Absolutely! We've made sure the changes are compatible with your current setup. Your workflows should continue to work just as before—if not better!
Do I need to do anything special after merging?
Nope! Just merge this PR, and you're all set. If you have any custom configurations, it's a good idea to give them a quick look to ensure everything's in order.
What if I run into issues or have concerns?
We're here to help! Feel free to reach out to our support team anytime.
Thanks for being awesome and keeping your configuration up-to-date! If you have any thoughts or need a hand, don't hesitate to let us know.
Happy merging! 🎉