PHP 8 & Symfony 6 #1153
Merged
PHP 8 & Symfony 6 #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Ci is nog niet blij :( |
NathanHuisman
force-pushed
the
php8-symfony6
branch
2 times, most recently
from
649e802 to
a810a62
Compare
De UserInterface is veranderd, de method 'getUsername' is veranderd naar de method 'getUserIdentifier'.
De constructor signature van UsernamePasswordToken is veranderd
NathanHuisman
force-pushed
the
php8-symfony6
branch
from
a810a62 to
5b914e7
Compare
Verander alle routing annotations naar attributes
Hierbij is ook de manier waarop de app geladen wordt veranderd, configuratie.include.php wordt op dit moment niet geladen TODO: We moeten deze hele logica veranderen om een beetje overeen te komen met best practices.
| @@ -102,7 +102,6 @@ package-lock.json | |||
| ###< phpunit/phpunit ### | |||
|
|
|||
| ###> symfony/phpunit-bridge ### | |||
| .phpunit | |||
.idea/php.xml
Outdated
| @@ -222,7 +222,7 @@ | |||
| <path value="$PROJECT_DIR$/vendor/twig/string-extra" /> | |||
| </include_path> | |||
| </component> | |||
| <component name="PhpProjectSharedConfiguration" php_language_level="7.3"> | |||
| <component name="PhpProjectSharedConfiguration" php_language_level="8.1"> | |||
There was a problem hiding this comment.
Deze moet ook nog even naar 8.2
| @@ -1,16 +1,16 @@ | |||
| FROM php:7.3-apache | |||
| FROM php:8.1-apache | |||
| { | ||
| public function __construct( | ||
| private readonly EntityManagerInterface $entityManager, | ||
| private readonly ObjectNormalizer $normalizer | ||
| ) { | ||
| } | ||
|
|
||
| public function getSupportedTypes(?string $format): array { |
There was a problem hiding this comment.
Op dit moment de meest veilige optie, ik weet niet hoe het caching mechanisme precies werkt
| @@ -1,11 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- https://phpunit.readthedocs.io/en/latest/configuration.html --> | |||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd" backupGlobals="false" colors="true" bootstrap="tests/bootstrap.php"> | |||
| <coverage processUncoveredFiles="true"> | |||
There was a problem hiding this comment.
Coverage is wel handig om te hebben, we moeten maar even kijken hoe we dat het best kunnen configureren
| @@ -12,3 +12,7 @@ | |||
| } elseif (method_exists(Dotenv::class, 'bootEnv')) { | |||
| (new Dotenv())->bootEnv(dirname(__DIR__) . '/.env'); | |||
| } | |||
|
|
|||
| if ($_SERVER['APP_DEBUG']) { | |||
There was a problem hiding this comment.
Waar is dit voor nodig?
In plaats van een flash message, log een error. TODO: Gebrek aan LDAP minder problematisch maken
|
NathanHuisman
requested changes
Nov 1, 2024
NathanHuisman
force-pushed
the
php8-symfony6
branch
from
5db5499 to
e0fe5f4
Compare
Whoops, dan moeten we natuurlijk ook ervoor zorgen dat CI de screenshots oppakt...
NathanHuisman
force-pushed
the
php8-symfony6
branch
2 times, most recently
from
844d1aa to
e63b46b
Compare
Verwijder git branch in logs, die gebruiken we toch niet
NathanHuisman
force-pushed
the
php8-symfony6
branch
from
e63b46b to
702a752
Compare
De twig alias bestond al, maar was private. Deze config werkte dus niet waardoor het niet gegarandeerd is dat twig ook in de container zit. Fix dit door een nieuwe publieke alias `csr.hack.twig` te maken (want het is een hack). Dit zou niet nodig moeten zijn en kan weggegooid worden ~wanneer~ als we de ContainerFacade voorgoed uit de code verbannen.
|
NathanHuisman
approved these changes
Feb 8, 2025
NathanHuisman
added a commit
that referenced
this pull request
Feb 10, 2025
Revert "Merge pull request #1153 from csrdelft/php8-symfony6"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zodra de stek naar PHP 8 kan natuurlijk