Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cstrans-df-run: improve matching of comments #148

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Nov 3, 2023

... so that cspodman can successfully scan quay-builder-container-v3.10.0-15

@kdudka kdudka requested a review from rhyw November 3, 2023 12:52
@kdudka kdudka self-assigned this Nov 3, 2023
... so that `cspodman` can successfully scan
`quay-builder-container-v3.10.0-15`

Related: https://issues.redhat.com/browse/OSH-391
Although it does not make any sense, `podman build` seems to do it as
well while parsing `Dockerfile`.  We need to emulate this behavior to
stay compatible.

Resolves: https://issues.redhat.com/browse/OSH-391
Closes: csutils#148
Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhyw
Copy link
Contributor

rhyw commented Nov 8, 2023

Had a verification, with quay-builder-container-v3.10.0-15, success.

@kdudka
Copy link
Member Author

kdudka commented Nov 8, 2023

Thank you both for review!

@kdudka kdudka closed this in d059bc7 Nov 8, 2023
@kdudka kdudka merged commit d059bc7 into csutils:main Nov 8, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants