Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snyk: skip writing of scan metadata when no supported project #155

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

jperezdealgaba
Copy link
Collaborator

Reproducer: csmock -r rhel-9-x86_64 -t snyk -f octavia-amphora-image-vert-fips-x86_64-18.0-20240305.1.el9ost.src.rpm

Related: https://issues.redhat.com/browse/OSH-583

When an snyk-unsupported project is scanned using snyk, no stats are generated.

@kdudka
Copy link
Member

kdudka commented Mar 18, 2024

The fix looks good. The commit message should say skip writing of scan metadata rather than fix generation of stats.

Reproducer: csmock -r rhel-9-x86_64 -t snyk -f octavia-amphora-image-vert-fips-x86_64-18.0-20240305.1.el9ost.src.rpm

Related: https://issues.redhat.com/browse/OSH-583

When an snyk-unsupported project is scanned using snyk, no stats are generated.
@kdudka kdudka changed the title snyk: fix generation of stats when no supported project snyk: skip writing of scan metadata when no supported project Mar 18, 2024
@jperezdealgaba
Copy link
Collaborator Author

Modified commit message

@kdudka kdudka self-assigned this Mar 18, 2024
@kdudka kdudka merged commit b90b8e8 into csutils:main Mar 18, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants