clippy: make the cargo wrapper work in bash #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzaoral
approved these changes
Jun 3, 2024
It turned out that the last change was not properly tested.
The previously used syntax is not recognized by bash:
```
[...]
cd ./librsvg && \
PKG_CONFIG_ALLOW_CROSS=1 \
PKG_CONFIG='/usr/bin/pkg-config' \
CARGO_TARGET_DIR=/builddir/build/BUILD/librsvg-2.50.7/target \
cargo --locked build --verbose --release \
&& cd /builddir/build/BUILD/librsvg-2.50.7 && /bin/sh ./libtool --tag=CC --mode=link gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64-v2 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -o librsvg_c_api.la _rsvg_dummy.lo && mv /builddir/build/BUILD/librsvg-2.50.7/target/release/librsvg_c_api.a .libs/librsvg_c_api.a
/usr/bin/cargo: line 5: ${@[i]}: bad substitution
[...]
```
This commit fixes it. Moreover, the invocation of `cargo_original` was
wrong because the wrapper path was passed as the first command-line arg
by mistake:
```
[...]
cd ./librsvg && \
PKG_CONFIG_ALLOW_CROSS=1 \
PKG_CONFIG='/usr/bin/x86_64-redhat-linux-gnu-pkg-config' \
CARGO_TARGET_DIR=/builddir/build/BUILD/librsvg-2.50.7/target \
cargo --locked build --verbose --release \
&& cd /builddir/build/BUILD/librsvg-2.50.7 && /bin/sh ./libtool --tag=CC --mode=link gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=forma
+ /usr/bin/cargo_original /usr/bin/cargo --locked clippy --verbose --release --message-format=json
error: running `/usr/bin/cargo` requires `-Zscript`
+ break
+ exec /usr/bin/cargo_original --locked build --verbose --release
[...]
```
Related: https://issues.redhat.com/browse/OSH-30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out that the last change was not properly tested.
The previously used syntax is not recognized by bash:
This commit fixes it. Moreover, the invocation of
cargo_originalwaswrong because the wrapper path was passed as the first command-line arg
by mistake:
Related: https://issues.redhat.com/browse/OSH-30