Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evb calibrated data #1288

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Evb calibrated data #1288

wants to merge 3 commits into from

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Sep 17, 2024

Found issues:

  • lstchain_data_r0_to_dl1 tries to access non-existing r0 waveform and perform gain selection on it

@maxnoe maxnoe linked an issue Sep 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.54%. Comparing base (e4a5b7a) to head (dcf9d2b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1288      +/-   ##
==========================================
+ Coverage   73.49%   73.54%   +0.05%     
==========================================
  Files         134      134              
  Lines       14210    14231      +21     
==========================================
+ Hits        10443    10466      +23     
+ Misses       3767     3765       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moralejo
Copy link
Collaborator

moralejo commented Nov 7, 2024

@maxnoe can we close this?

@maxnoe
Copy link
Member Author

maxnoe commented Nov 7, 2024

You mean finish? Or really just close? What is the alternative solution if we close?

@moralejo
Copy link
Collaborator

moralejo commented Nov 7, 2024

I meant finish, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Processing of data with PE calibration applied by EVB
2 participants