Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jinja pin #1289

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Remove jinja pin #1289

merged 1 commit into from
Oct 8, 2024

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Sep 17, 2024

Should not be needed anymore and fixes a dependabot alert

morcuended
morcuended previously approved these changes Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.50%. Comparing base (cc1441f) to head (8bbcf7d).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1289   +/-   ##
=======================================
  Coverage   73.50%   73.50%           
=======================================
  Files         134      134           
  Lines       14210    14210           
=======================================
  Hits        10445    10445           
  Misses       3765     3765           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe
Copy link
Member Author

maxnoe commented Sep 17, 2024

There are scheduled maintenance downtimes today at in2p3, where the dataserver of the ctapipe test data is hosted, that's why the tests keep failing with connection issues

morcuended
morcuended previously approved these changes Sep 18, 2024
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fail is unrelated (due to non deterministic test of the IRF scaling factor)

@morcuended
Copy link
Member

I think this can be merged already

@rlopezcoto
Copy link
Contributor

one of the tests was giving troubles, I am re-running it now...

@morcuended
Copy link
Member

After merging #1300, I hope this test will not cause problems anymore.

@morcuended
Copy link
Member

this can be merged

@maxnoe maxnoe merged commit ddcf4f9 into main Oct 8, 2024
9 checks passed
@maxnoe maxnoe deleted the maxnoe-patch-1 branch October 8, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants