Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option single_ob to HDF5Merger for merging chunks of the same ob #2436

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Add option single_ob to HDF5Merger for merging chunks of the same ob

13ea0ff
Select commit
Loading
Failed to load commit list.
Draft

Add option single_ob to HDF5Merger for merging chunks of the same ob #2436

Add option single_ob to HDF5Merger for merging chunks of the same ob
13ea0ff
Select commit
Loading
Failed to load commit list.
CTAO-DPPS-SonarQube / ctapipe Sonarqube Results failed Feb 5, 2025 in 14s

Quality Gate failed

Failed

  • B Maintainability Rating on New Code (is worse than A)
  • 60.00% Coverage on New Code (is less than 80.00%)

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage 60.00% Coverage (94.10% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.70% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

Annotations

Check failure on line 316 in src/ctapipe/io/hdf5merger.py

See this annotation in the file changed.

@ctao-dpps-sonarqube ctao-dpps-sonarqube / ctapipe Sonarqube Results

src/ctapipe/io/hdf5merger.py#L316 

Refactor this function to reduce its Cognitive Complexity from 55 to the 15 allowed.
View more details on CTAO-DPPS-SonarQube