Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalized the names of reconstruction classes #407

Merged
merged 4 commits into from
May 9, 2017

Conversation

kosack
Copy link
Contributor

@kosack kosack commented May 9, 2017

As part of the effort to start to clean up all reconstruction algorithms (and allow more to be implemented), I've renamed a few classes. These also now match the naming rules in the software standards docs.

  • RecoShowerGeomAlgorithm → Reconstructor (base class)
  • FitGammaHillas → HillasReconstructor
  • ImPACTFitter → ImPACTReconstructor

Any objections?

- RecoShowerGeomAlgorithm → Reconstructor (base class)
- FitGammaHillas → HillasReconstructor
- ImPACTFitter → ImPACTReconstructor
@ParsonsRD
Copy link
Member

Fine by me

@kosack kosack merged commit b4b159c into cta-observatory:master May 9, 2017
kosack added a commit that referenced this pull request Jan 30, 2018
normalized the names of reconstruction classes
@kosack kosack deleted the rename_reco branch May 20, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants