Auto mcp w/o MC

[Elisa-Visentin]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (81482b8) to head (827239c).

Additional details and impacted files

@@               Coverage Diff                @@
##           Torino_auto_MCP     #243   +/-   ##
================================================
  Coverage            77.23%   77.23%           
================================================
  Files                   21       21           
  Lines                 2614     2614           
================================================
  Hits                  2019     2019           
  Misses                 595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Elisa-Visentin]

(Seems to be) completely removed now

[jsitarek]

You should also update README.md, because it also describes MC processing with auto_MCP, e.g.:

magic-cta-pipe/magicctapipe/scripts/lst1_magic/README.md

Line 36 in 40d483d

The file `config_auto_MCP.yaml` must contain the telescope IDs, the directories with the MC data (ignored if you set NSB_matching = true), the data selection, and some information on the night sky background (NSB) level and software versions:

[jsitarek]

I checked all the changed files in here, and also zoomed over other modified files from Torino_auto_MCP branch to see if anything else should be removed, but except of updates in readme file I think you did it all already

[Elisa-Visentin]

Fixed the readme (also for tel_ids in the config file, which is the other open PR)

[Elisa-Visentin]

There are a couple of conflicts now. I'm trying to solve them

[jsitarek]

in the readme file:
/fefs/aswg/workspace/yourname/yourprojectname/VERSION/
should be
{workspace_dir}/yourprojectname/VERSION/
(and similar the other lines below). Normally indeed it will look like in your original example, but not in the case of "official" processing that Joanna will run

[Elisa-Visentin]

Oh yes thanks I will fix it now. In the mean time, there were some troubles with the merging with master (some 'conflicts' were not reported as conflicts but automatically solved in the wrong way). But they should be fixed now