Vote functionality #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ctco-dev/event-organizer into vote_counter # Conflicts: # src/main/webapp/app/jsp/event.jsp
…/ctco-dev/event-organizer into vote_counter # Conflicts: # src/main/webapp/app/jsp/event.jsp
…-dev/event-organizer into vote_counter # Conflicts: # src/main/webapp/javascript/event.js
FLARS
reviewed
Sep 7, 2018
| private User author; | ||
|
|
||
| private String date; | ||
| private String time; | ||
| private String eventName; |
There was a problem hiding this comment.
I believe that this refactoring is redundant. Because we are working with Event entity we know that name corresponds to it and we don't need to explicitly say that it's eventName.
Same for other attributes.
| @@ -18,7 +18,7 @@ | |||
| @JoinColumn(name = "poll_id") | |||
| private Poll poll; | |||
|
|
|||
| private int counter; | |||
| private int counter = 0; | |||
There was a problem hiding this comment.
I believe that all Java primitives has default value and as they are primitives they can't be null.
As far as I know default value of int is 0
| @@ -18,7 +18,7 @@ | |||
| @JoinColumn(name = "poll_id") | |||
| private Poll poll; | |||
|
|
|||
| private int counter; | |||
| private int counter = 0; | |||
There was a problem hiding this comment.
I belive that all Java primitives has default value and as they are primitives they can't be null.
As far as I know default value of int is 0
GatisFr
previously approved these changes
Sep 7, 2018
FLARS
approved these changes
Sep 7, 2018
GatisFr
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
mvn testfrom the root directory to see all new and existing tests passMotivation and Context
#59
Description
vote count and radio button hides after vote, create user-poll entity, impossibility of a repeat vote, validation duplicate vote and hide poll