Skip to content

Conversation

@phlip9
Copy link
Contributor

@phlip9 phlip9 commented May 17, 2025

Figured I'd pull this change out into a separate diff.

As discussed here: #74 (comment)

The "page-alignment" required for adrp is fixed from the aarch64 ISA at 4 KiB and doesn't actually represent the machine's physical page size.

With this change, we can save a bit of .data by reducing alignment for constants on aarch64 from 16 KiB -> 4 KiB.

The "page-alignment" required for `adrp` is fixed from the aarch64 ISA
at 4 KiB and doesn't actually represent the machine's physical page size.
@codecov
Copy link

codecov bot commented May 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.31%. Comparing base (7be7d89) to head (842863b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files         168      168           
  Lines       40284    40284           
=======================================
  Hits        40009    40009           
  Misses        275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented May 17, 2025

CodSpeed Performance Report

Merging #87 will degrade performances by 28.09%

Comparing phlip9:phlip9/aarch64-adrp-4kib-align (842863b) with main (7be7d89)

Summary

❌ 4 regressions
✅ 130 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
graviola[8KB] 18.5 µs 20.6 µs -10.27%
graviola[8KB] 19.3 µs 21.5 µs -10.11%
rustcrypto[32B] 9.2 µs 12.8 µs -28.09%
rustcrypto[32B] 4 µs 5.1 µs -20.73%

@ctz ctz merged commit 94b6bcf into ctz:main May 17, 2025
13 of 15 checks passed
@ctz
Copy link
Owner

ctz commented May 17, 2025

Thanks!

@phlip9 phlip9 deleted the phlip9/aarch64-adrp-4kib-align branch May 17, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants