Skip to content

fix(ItemBase): tooltip logic #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ItemBase): tooltip logic #812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions src/components/content/ItemBase/ItemBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,21 +390,21 @@ export function useAutoTooltip({
}, [tooltip, children]);

// Track label overflow for auto tooltip (only when enabled)
const mergedLabelRef = useCombinedRefs((labelProps as any)?.ref);
const externalLabelRef = (labelProps as any)?.ref;
const [isLabelOverflowed, setIsLabelOverflowed] = useState(false);
const observedElementRef = useRef<HTMLElement | null>(null);
const elementRef = useRef<HTMLElement | null>(null);
const resizeObserverRef = useRef<ResizeObserver | null>(null);

const checkLabelOverflow = useCallback(() => {
const label = mergedLabelRef.current;
const label = elementRef.current;
if (!label) {
setIsLabelOverflowed(false);
return;
}

const hasOverflow = label.scrollWidth > label.clientWidth;
setIsLabelOverflowed(hasOverflow);
}, [mergedLabelRef]);
}, []);

useEffect(() => {
if (isAutoTooltipEnabled) {
Expand All @@ -415,8 +415,14 @@ export function useAutoTooltip({
// Attach ResizeObserver via callback ref to handle DOM node changes
const handleLabelElementRef = useCallback(
(element: HTMLElement | null) => {
// Sync to combined ref so external refs receive the node
(mergedLabelRef as any).current = element;
// Call external callback ref to notify external refs
if (externalLabelRef) {
if (typeof externalLabelRef === 'function') {
externalLabelRef(element);
} else {
(externalLabelRef as any).current = element;
}
}

// Disconnect previous observer
if (resizeObserverRef.current) {
Expand All @@ -428,7 +434,7 @@ export function useAutoTooltip({
resizeObserverRef.current = null;
}

observedElementRef.current = element;
elementRef.current = element;

if (element && isAutoTooltipEnabled) {
// Create a fresh observer to capture the latest callback
Expand All @@ -443,7 +449,7 @@ export function useAutoTooltip({
setIsLabelOverflowed(false);
}
},
[mergedLabelRef, isAutoTooltipEnabled, checkLabelOverflow],
[externalLabelRef, isAutoTooltipEnabled, checkLabelOverflow],
);

// Cleanup on unmount
Expand All @@ -457,7 +463,7 @@ export function useAutoTooltip({
}
resizeObserverRef.current = null;
}
observedElementRef.current = null;
elementRef.current = null;
};
}, []);

Expand Down
Loading