Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update context.mdx #8900

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

morgan-at-cube
Copy link
Contributor

The masking function example in this document generates SQL like this:
SELECT "'--- masked ---'" "users__first_name" FROM ECOM.USERS AS "users"
This is incorrect because quotes indicate a column name. If we remove the escaped quotes, then the query works.

Definitely feel free to tell me I'm wrong, this is just what I experienced in testing!

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

Copy link

vercel bot commented Nov 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2024 0:13am

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant