Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema-compiler): use query timezone for time granularity origin #8936

Merged
merged 6 commits into from
Nov 23, 2024

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Nov 8, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 8:40pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 8:40pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 8:40pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 8:40pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 8:40pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 8:40pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 8:40pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 8:40pm

@KSDaemon KSDaemon force-pushed the fix/granularity-origin-utc branch from 11b611c to 525a796 Compare November 8, 2024 18:43
@KSDaemon KSDaemon marked this pull request as ready for review November 11, 2024 09:21
@KSDaemon KSDaemon requested a review from a team as a code owner November 11, 2024 09:21
@KSDaemon KSDaemon requested a review from a team as a code owner November 22, 2024 18:47
@KSDaemon KSDaemon force-pushed the fix/granularity-origin-utc branch from 0aa4f62 to a3028d5 Compare November 22, 2024 20:39
@KSDaemon KSDaemon merged commit 1beba2d into master Nov 23, 2024
57 checks passed
@KSDaemon KSDaemon deleted the fix/granularity-origin-utc branch November 23, 2024 21:00
ptiurin pushed a commit to firebolt-db/cube that referenced this pull request Nov 27, 2024
…ube-js#8936)

* fix(schema-compiler): use query timezone for time granularity origin

* fix tests

* small improvement

* fix dateBin implementation across all Queries (timeStampCast → dateTimeCast)

* Fix MS SQL timeStampCast

* fix ms sql test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants